Use `FormBuilder` to internationalize labels

When the system test is modified to translate other keys, the test fails:

Error:
UserSharesAMessageTest#test_visiting_the_index:
I18n::MissingTranslationData: translation missing: en.helpers.label.note.content
    test/system/user_shares_a_message_test.rb:9:in `block in <class:UserSharesAMessageTest>'

The key structure for this value is not arbitrary: it adheres to the conventions for Rails’ ActionView::Helpers::FormBuilder#label resolution API.

When we declare the corresponding internationalization keys, the system tests pass.

Finally, we can remove the String arguments from the notes#new template’s helper method calls to rely on the internationalization behavior.


      app/views/notes/new.html.erb

diff --git a/app/views/notes/new.html.erb b/app/views/notes/new.html.erb
index 5b230bb..f4a3ba3 100644
--- a/app/views/notes/new.html.erb
+++ b/app/views/notes/new.html.erb
@@ -1,6 +1,6 @@
 <%= form_with(model: note, method: :post, local: true) do |form| %>
-  <%= form.label(:content, "Message") %>
+  <%= form.label(:content) %>
   <%= form.text_area(:content) %>
 
-  <%= form.submit("Share") %>
+  <%= form.submit %>
 <% end %>


      config/locales/en.yml

diff --git a/config/locales/en.yml b/config/locales/en.yml
index 4c1b4fd..348d2b8 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -30,6 +30,14 @@
 # available at https://guides.rubyonrails.org/i18n.html.
 
 en:
+  helpers:
+    label:
+      note:
+        content: "Message"
+    submit:
+      note:
+        create: "Share"
+
   notes:
     index:
       new: "Share a Note"


      test/system/user_shares_a_message_test.rb

diff --git a/test/system/user_shares_a_message_test.rb b/test/system/user_shares_a_message_test.rb
index d6339f8..51c9d39 100644
--- a/test/system/user_shares_a_message_test.rb
+++ b/test/system/user_shares_a_message_test.rb
@@ -6,8 +6,8 @@ class UserSharesAMessageTest < ApplicationSystemTestCase
 
     visit root_path
     click_on translate("notes.index.new")
-    fill_in "Message", with: content
-    click_on "Share"
+    fill_in translate("helpers.label.note.content"), with: content
+    click_on translate("helpers.submit.note.create")
 
     assert_text content
   end

Use FormBuilder to internationalize labels

Use `FormBuilder` to internationalize labels